workflow: codesign macOS builds #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpotter92
commented
Apr 5, 2022
| run: echo "GOARCH=${{ matrix.arch }}" >> $GITHUB_ENV | ||
| run: | | ||
| echo "GOARCH=${{ matrix.arch }}" >> $GITHUB_ENV | ||
| echo "GO_BUILD_DIR=lp-builds/" >> $GITHUB_ENV |
There was a problem hiding this comment.
could not find a way to generate a random build directory name and still use it later for codesigning stage. hardcoded as lp-builds here until then.
leszko
reviewed
Apr 6, 2022
There was a problem hiding this comment.
Added one comment. Other than that, it looks good. Thanks for the PR @hjpotter92
leszko
approved these changes
Apr 6, 2022
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
The macOS binaries are signed using apple developer certificates
Specific updates (required)
GO_BUILD_DIRvariable, to output built binaries to custom pathHow did you test each of these updates (required)
gh-action runs
Checklist:
makeruns successfully./test.shpass