eth, pm: Use previous round L1 block for ticket expiration if the current block hash is zero #2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
reviewed
Apr 12, 2022
…rent block hash is zero
Co-authored-by: Yondon Fu <yondon.fu@gmail.com>
Co-authored-by: Yondon Fu <yondon.fu@gmail.com>
leszko
force-pushed
the
2360-backdata-tickets-zero-block-hash
branch
from
d6dcb5b
to
621fab7
Compare
|
@yondonfu I've incorporated your suggestions, added unit tests, and fixed the linter. PTAL. |
ad-astra-video
pushed a commit
to ad-astra-video/go-livepeer
that referenced
this pull request
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Arbitrum sometimes returns
0x00as the L1 Block Hash. To prevent a situation when all Os cannot receive tickets for the whole round, we can use the previous round as the ticket expiration parameter.Specific updates (required)
How did you test each of these updates (required)
streamflowcontractsDoes this pull request close any open issues?
fix #2360
Checklist:
makeruns successfully./test.shpassREADME and other documentation updated