Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Change verification randomness variable meaning #2385

Merged
merged 3 commits into from
May 6, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented May 6, 2022

What does this pull request do? Explain your changes. (required)
Change the meaning of the "Verification Frequency" parameter from meaning the odds of it running on a given request are 1 - 1 / VerificationFreq to 1 / VerificationFreq

How did you test each of these updates (required)
Wrote unit tests for method that calulates the odds

Does this pull request close any open issues?
No

Checklist:

Copy link
Contributor

@oscar-davids oscar-davids left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #2385 (db0eac3) into master (e3f9286) will increase coverage by 0.02104%.
The diff coverage is 94.11765%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2385         +/-   ##
===================================================
+ Coverage   54.48659%   54.50763%   +0.02103%     
===================================================
  Files             93          93                 
  Lines          19458       19467          +9     
===================================================
+ Hits           10602       10611          +9     
  Misses          8267        8267                 
  Partials         589         589                 
Impacted Files Coverage Δ
server/broadcast.go 78.22507% <94.11765%> (+0.18079%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3f9286...db0eac3. Read the comment docs.

@thomshutt thomshutt merged commit 1e5ce2a into master May 6, 2022
@thomshutt thomshutt deleted the thom/verification-randomness branch May 6, 2022 13:30
ad-astra-video pushed a commit to ad-astra-video/go-livepeer that referenced this pull request May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants