Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only write session end log message if session exists #2777

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Only write session end log message if session exists #2777

merged 2 commits into from
Mar 24, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Mar 23, 2023 •
edited

What does this pull request do? Explain your changes. (required)

We will now only write a session end log message if the session was found on the orchestrator.

Specific updates (required)

How did you test each of these updates (required)

  • Tested sessions locally to check the log message appears when expected.
  • Tested on a single O for a few days and observed the expected log messages.

Does this pull request close any open issues?

Fixes #2755

Checklist:

@mjh1 mjh1 requested review from leszko and thomshutt March 24, 2023 11:38
@mjh1 mjh1 merged commit db28a19 into master Mar 24, 2023
@mjh1 mjh1 deleted the mh/stream-end-log branch March 24, 2023 12:57
This was referenced Aug 8, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomshutt thomshutt thomshutt approved these changes

@leszko leszko leszko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transcoding session ended by the Broadcaster when no sessions were transcoded
3 participants
@mjh1 @thomshutt @leszko