Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip transcoding when empty profiles were sent to B #2883

Merged
merged 4 commits into from Oct 6, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 6, 2023

This PR distinguishes between empty profiles and profiles not sent.

  • no profiles {} => use default profiles
  • empty profiles {"profiles":[]} => skip transcoding, only source is avaible

@leszko leszko requested a review from thomshutt October 6, 2023 13:28
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #2883 (d2acce4) into master (aa79cf5) will increase coverage by 0.00900%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2883         +/-   ##
===================================================
+ Coverage   56.37255%   56.38155%   +0.00900%     
===================================================
  Files             89          89                 
  Lines          19380       19384          +4     
===================================================
+ Hits           10925       10929          +4     
  Misses          7849        7849                 
  Partials         606         606                 
Files Coverage Δ
server/broadcast.go 77.61317% <100.00000%> (+0.05541%) ⬆️
server/mediaserver.go 67.22689% <100.00000%> (+0.02506%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa79cf5...d2acce4. Read the comment docs.

Files Coverage Δ
server/broadcast.go 77.61317% <100.00000%> (+0.05541%) ⬆️
server/mediaserver.go 67.22689% <100.00000%> (+0.02506%) ⬆️

@leszko leszko merged commit 4e55d0c into master Oct 6, 2023
18 checks passed
@leszko leszko deleted the rafal/skip-transcoding branch October 6, 2023 14:39
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants