Fix price per session

[leszko]

fix #2891

[codecov]

Codecov Report

Merging #2892 (2d8c94b) into master (32d5d45) will increase coverage by 0.01121%.
The diff coverage is 100.00000%.

❗ Current head 2d8c94b differs from pull request most recent head 0f621ac. Consider uploading reports for the commit 0f621ac to get more accurate results

@@                 Coverage Diff                 @@
##              master       #2892         +/-   ##
===================================================
+ Coverage   56.45344%   56.46465%   +0.01121%     
===================================================
  Files             89          89                 
  Lines          19416       19421          +5     
===================================================
+ Hits           10961       10966          +5     
  Misses          7849        7849                 
  Partials         606         606                 

Files	Coverage Δ
server/broadcast.go	77.97571% <100.00000%> (+0.01785%)	⬆️
server/rpc.go	72.10682% <ø> (ø)
server/segment_rpc.go	78.48837% <100.00000%> (+0.12580%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32d5d45...0f621ac. Read the comment docs.

Files	Coverage Δ
server/broadcast.go	77.97571% <100.00000%> (+0.01785%)	⬆️
server/rpc.go	72.10682% <ø> (ø)
server/segment_rpc.go	78.48837% <100.00000%> (+0.12580%)	⬆️

[thomshutt]

Looks good but this will mean every time an O increases their prices, they lose sessions right? I think this is good as a patch for the vulnerability, but does somewhat limit the ability of the Os to do dynamic pricing changes without losing out on work

[0xspeedybird]

This approach is not comprehensive and prevents the market dynamics promoted during the recent selection algo updates. Please review the comments on #2891.

[Titan-Node]

I would rather see a comprehensive fix than just a patch to fix the "vulnerability" today. Technically it's not actually costing the B any more funds than they would have prior to the algo change, Os can still only increase it to less than the maxPrice the B sets.

If we implement this as it stands all Os started by default that do not include the autoPriceAdjust flag will fail to work.

[eliteprox]

I agree, we should keep the same price during the entire stream. Dropping session when the price changes isn't an acceptable solution imho.

[Titan-Node]

The Orch would need to cache the price per orchSessionID and maintain that price until that session ends

[leszko]

Thanks for all the comments. I think you're right. Let's wait with merging this PR until I send a fix for O to keep the price the same during the whole session.

[leszko]

Updated the PR. Now:

• Orchestrator fixes the price per session
• Broadcaster checks if the price was not increased

@Titan-Node @eliteprox @0xspeedybird @thomshutt PTAL.

[thomshutt]

LGTM!