Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-maxTotalEV' flag #2897

Merged
merged 3 commits into from Oct 25, 2023
Merged

Add '-maxTotalEV' flag #2897

merged 3 commits into from Oct 25, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Oct 23, 2023

This allows B to set separately:

  • Max single ticket EV
  • Max total EV for one payment

@leszko leszko requested a review from thomshutt October 23, 2023 13:25
@papabear99
Copy link
Contributor

This was brought up in the watercooler chat. What's the purpose of this pr?

@leszko
Copy link
Contributor Author

leszko commented Oct 24, 2023

This was brought up in the watercooler chat. What's the purpose of this pr?

The context is that the current -maxTicketEV flag set in B has 2 purposes:

  • Sets the maximum -ticketEV accepted from O
  • Sets the maximum total ticket EV sent with one segment

So, we split it into 2 flags. The broader context is that the current ticket EV is usually set to a too-high value, which means overpaying by B for short videos.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #2897 (6425606) into master (1c2ce07) will decrease coverage by 0.00108%.
Report is 1 commits behind head on master.
The diff coverage is 47.61905%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2897         +/-   ##
===================================================
- Coverage   56.45311%   56.45203%   -0.00108%     
===================================================
  Files             89          89                 
  Lines          19448       19459         +11     
===================================================
+ Hits           10979       10985          +6     
- Misses          7861        7866          +5     
  Partials         608         608                 
Files Coverage Δ
cmd/livepeer/livepeer.go 50.00000% <100.00000%> (+0.51020%) ⬆️
pm/sender.go 100.00000% <100.00000%> (ø)
cmd/livepeer/starter/starter.go 4.70685% <0.00000%> (-0.01952%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c2ce07...6425606. Read the comment docs.

Files Coverage Δ
cmd/livepeer/livepeer.go 50.00000% <100.00000%> (+0.51020%) ⬆️
pm/sender.go 100.00000% <100.00000%> (ø)
cmd/livepeer/starter/starter.go 4.70685% <0.00000%> (-0.01952%) ⬇️

@leszko leszko merged commit 366c2d6 into master Oct 25, 2023
18 checks passed
@leszko leszko deleted the rafal/fix-max-ticket-ev branch October 25, 2023 08:48
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants