Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return parsing error when failing to parse B prices #2958

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

thomshutt
Copy link
Contributor

What does this pull request do? Explain your changes. (required)

  • Return the parsing error when per-Broadcaster pricing is being specified as a JSON blob and parsing of that blob fails.

How did you test each of these updates (required)

  • Ran unit tests
  • Intentionally misconfigured CLI option and observed error

Does this pull request close any open issues?

  • No

Checklist:

@thomshutt thomshutt requested a review from leszko January 23, 2024 15:30
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (7c07265) 56.63745% compared to head (f972db3) 56.67067%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #2958         +/-   ##
===================================================
+ Coverage   56.63745%   56.67067%   +0.03322%     
===================================================
  Files             89          89                 
  Lines          19164       19151         -13     
===================================================
- Hits           10854       10853          -1     
+ Misses          7718        7706         -12     
  Partials         592         592                 
Files Coverage Δ
server/redeemer.go 91.35338% <ø> (ø)
server/router.go 0.00000% <ø> (ø)
server/rpc.go 70.15873% <ø> (ø)
cmd/livepeer/starter/starter.go 4.76190% <0.00000%> (-0.08092%) ⬇️
core/os.go 19.04762% <12.50000%> (-0.95238%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace2697...f972db3. Read the comment docs.

Files Coverage Δ
server/redeemer.go 91.35338% <ø> (ø)
server/router.go 0.00000% <ø> (ø)
server/rpc.go 70.15873% <ø> (ø)
cmd/livepeer/starter/starter.go 4.76190% <0.00000%> (-0.08092%) ⬇️
core/os.go 19.04762% <12.50000%> (-0.95238%) ⬇️

... and 1 file with indirect coverage changes

@thomshutt thomshutt merged commit 73e1808 into master Jan 24, 2024
18 checks passed
@thomshutt thomshutt deleted the prices-err branch January 24, 2024 09:40
@thomshutt thomshutt mentioned this pull request Jan 29, 2024
eliteprox pushed a commit to eliteprox/go-livepeer that referenced this pull request Feb 21, 2024
* Return parsing error when failing to parse B prices

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants