fix(ai): prevent insufficient capacity payments #3035
Merged
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
fix_insufficient_capacity_payments
branch
from
ad0f896
to
018ddbf
Compare
rickstaa
force-pushed
the
fix_insufficient_capacity_payments
branch
from
018ddbf
to
d4917a7
Compare
eliteprox
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
This change looks good. I ran an image-to-video request and then sent a 2nd request as it was processing. Debug flow shows AI Core catches the request and returns Insufficient Capacity to the gateway. Due to current selection algorithm logic, it does try up to 4 times to process the request.
E0429 09:26:28.144456 1611365 handlers.go:1511] HTTP Response Error 503: Insufficient capacity for pipeline=image-to-video modelID=stabilityai/stable-video-diffusion-img2vid-xt-1-1
5 tasks
|
@yondonfu, I've reviewed the payment workflow and it appears to be functioning as expected. Could you quickly confirm if you see any issues with this fix? |
Looks reasonable! |
This commit enhances the Orchestrator's capacity handling by returning an error prior to processing payments when capacity is insufficient. This prevents that the Gateway overpays for requests.
rickstaa
force-pushed
the
fix_insufficient_capacity_payments
branch
from
d4917a7
to
e6a09d9
Compare
This commit updates the ai-worker dependency to the latest version.
This was referenced May 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on livepeer/ai-worker#73 to be merged. Additionally the
mod.gofile should be updated to poitn to the right worker commit.What does this pull request do? Explain your changes. (required)
This commit enhances the Orchestrator's capacity handling by returningan error prior to processing payments when capacity is insufficient. This prevents that the Gateway overpays for requests.
Specific updates (required)
CheckAICapacitywas added to thecore/orchestrator.gofile.handleAIRequestmethod was changed so that the O first checks whether it can process a request before processing a payment.How did you test each of these updates (required)
Does this pull request close any open issues?
https://linear.app/livepeer-ai-spe/issue/LIV-175/orchestrators-get-paid-for-unsuccessful-jobs
Checklist:
makeruns successfully./test.shpass