Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctx to logging for selection algorithm #3080

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Jun 14, 2024

Copy link

linear bot commented Jun 14, 2024

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@victorges
Copy link
Member

Gotta update tests, I guess just the signature that broke from the test code

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.40929%. Comparing base (df4c106) to head (a01b36e).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #3080   +/-   ##
=============================================
  Coverage   57.40929%   57.40929%           
=============================================
  Files             92          92           
  Lines          15764       15764           
=============================================
  Hits            9050        9050           
  Misses          6111        6111           
  Partials         603         603           
Files Coverage Δ
common/types.go 0.00000% <ø> (ø)
server/selection.go 93.10345% <100.00000%> (ø)
server/selection_algorithm.go 89.23077% <77.77778%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4c106...a01b36e. Read the comment docs.

Files Coverage Δ
common/types.go 0.00000% <ø> (ø)
server/selection.go 93.10345% <100.00000%> (ø)
server/selection_algorithm.go 89.23077% <77.77778%> (ø)

@leszko leszko merged commit b62c60c into master Jun 14, 2024
18 checks passed
@leszko leszko deleted the rafal/add-context-to-selection-algorithm-logging branch June 14, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants