views: Improve API ergonomy #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
victorges
commented
Jun 28, 2023
•
victorges
commented
- Separate null from not-asked fields
- Fix "exists before starts" typo 馃き
- Allow querying global account metrics
- added viewerId and creatorId to breakdownBy fields
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
===================================================
+ Coverage 26.53722% 27.93651% +1.39929%
===================================================
Files 4 4
Lines 309 315 +6
===================================================
+ Hits 82 88 +6
- Misses 215 217 +2
+ Partials 12 10 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
ecmulli
reviewed
Jun 28, 2023
ecmulli
reviewed
Jun 28, 2023
ecmulli
reviewed
Jun 28, 2023
victorges
force-pushed
the
vg/feat/cleaner-api
branch
from
2a12f16
to
96411fc
Compare
* added viewerid and creatorid to the events query * Update views/client.go Co-authored-by: Victor Elias <victor@livepeer.org> * updated to casing --------- Co-authored-by: Victor Elias <victor@livepeer.org>
* added viewerid and creatorid to the events query * Update views/client.go Co-authored-by: Victor Elias <victor@livepeer.org> * updated to casing * added geohash --------- Co-authored-by: Victor Elias <victor@livepeer.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.