HLS changes #20
Merged
HLS changes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dob
reviewed
May 1, 2017
There was a problem hiding this comment.
Nice work. Do you want to remove the lpms binary file from the repo? (https://help.github.com/articles/removing-files-from-a-repository-s-history/)
| } | ||
|
|
||
| func NewHLSBuffer() *HLSBuffer { |
There was a problem hiding this comment.
Should we just leave this method and invoke the new method with a default capacity?
There was a problem hiding this comment.
Golang doesn't have method overload, which makes things a little annoying to maintain (cannot just add a new param in the constructor without changing existing code). Not sure what's the best practice here. I can add a "NewHLSBufferWithCap", but maybe it's good to enforce the cap for this case (following the same pattern as grafov/m3u8).
|
Also removed lpms binary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is related to how HLS is treated in LPMS.