Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the tooling of the codebase #566

Closed
RiccardoBiosas opened this issue May 10, 2022 · 2 comments
Closed

Standardize the tooling of the codebase #566

RiccardoBiosas opened this issue May 10, 2022 · 2 comments
Assignees

Comments

@RiccardoBiosas
Copy link
Contributor

Context
Currently the protocol codebase makes use of many different tools which have been adopted and then supplanted by more recent/suitable alternatives over time.
The tooling includes: web3 and hardhat/web3, ethereum-waffle and hardhat-waffle, ethers and hardhat-ethers, hardhat-deploy, foundry. Also it includes outdated/unused configuration files such as the Dockerfile / docker-compose.
Proposal
I propose to:

  • progressively converge the tooling of the javascript/typescript codebase to ethers
  • progressively move all the solidity tests to the foundry directory and run them as part of the foundry test suite (this shouldn't require any significant refactoring of the solidity tests)
  • remove all the outdated configuration files
@yondonfu
Copy link
Member

@RiccardoBiosas will break this up into smaller, more tightly scoped tasks.

@yondonfu
Copy link
Member

Closing because we've broken out smaller issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants