-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www: Switch cdn.livepeer.com to livepeercdn.com #1000
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/livepeer/livepeer-com/BynzNuQ6bKkyDgz2CghSa2tpAYd1 |
packages/www/docs/api-reference/session/list-recorded-sessions.mdx
Outdated
Show resolved
Hide resolved
packages/www/docs/guides/start-live-streaming/back-up-transcoding.mdx
Outdated
Show resolved
Hide resolved
@@ -305,7 +305,7 @@ const ID = () => { | |||
const playbackId = (stream || {}).playbackId || ""; | |||
const domain = isStaging() ? "monster" : "com"; | |||
const globalIngestUrl = `rtmp://rtmp.livepeer.${domain}/live`; | |||
const globalPlaybackUrl = `https://cdn.livepeer.${domain}/hls/${playbackId}/index.m3u8`; | |||
const globalPlaybackUrl = `https://livepeercdn.${domain}/hls/${playbackId}/index.m3u8`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have livepeercdn.monster
as well? We probably should cc @iameli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we're still using cdn.livepeer.monster
@@ -305,7 +305,7 @@ const ID = () => { | |||
const playbackId = (stream || {}).playbackId || ""; | |||
const domain = isStaging() ? "monster" : "com"; | |||
const globalIngestUrl = `rtmp://rtmp.livepeer.${domain}/live`; | |||
const globalPlaybackUrl = `https://cdn.livepeer.${domain}/hls/${playbackId}/index.m3u8`; | |||
const globalPlaybackUrl = `https://livepeercdn.${domain}/hls/${playbackId}/index.m3u8`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm funny, I swear I saw this page using the getIngest
API somewhere...
Hmm It actually does... don't know what's the difference between the 2
https://github.com/livepeer/livepeer-com/blob/1c9390d3490f6f7473d770d967c672599b3e7d51/packages/www/pages/app/stream/%5Bid%5D.tsx#L281
Change references of cdn.livepeer.com to livepeercdn.com in the dashboard and the docs
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional):
Checklist: