Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Switch cdn.livepeer.com to livepeercdn.com #1000

Merged
merged 6 commits into from
Apr 12, 2022
Merged

Conversation

gioelecerati
Copy link
Member

Change references of cdn.livepeer.com to livepeercdn.com in the dashboard and the docs

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Apr 11, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/livepeer/livepeer-com/BynzNuQ6bKkyDgz2CghSa2tpAYd1
✅ Preview: https://livepeer-com-git-gio-switch-cdn-livepeer.vercel.app

@gioelecerati gioelecerati requested a review from a team April 11, 2022 17:35
packages/www/docs/api-reference/ingest.mdx Outdated Show resolved Hide resolved
packages/www/components/Dashboard/AssetsTable/index.tsx Outdated Show resolved Hide resolved
@@ -305,7 +305,7 @@ const ID = () => {
const playbackId = (stream || {}).playbackId || "";
const domain = isStaging() ? "monster" : "com";
const globalIngestUrl = `rtmp://rtmp.livepeer.${domain}/live`;
const globalPlaybackUrl = `https://cdn.livepeer.${domain}/hls/${playbackId}/index.m3u8`;
const globalPlaybackUrl = `https://livepeercdn.${domain}/hls/${playbackId}/index.m3u8`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have livepeercdn.monster as well? We probably should cc @iameli

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we're still using cdn.livepeer.monster

@@ -305,7 +305,7 @@ const ID = () => {
const playbackId = (stream || {}).playbackId || "";
const domain = isStaging() ? "monster" : "com";
const globalIngestUrl = `rtmp://rtmp.livepeer.${domain}/live`;
const globalPlaybackUrl = `https://cdn.livepeer.${domain}/hls/${playbackId}/index.m3u8`;
const globalPlaybackUrl = `https://livepeercdn.${domain}/hls/${playbackId}/index.m3u8`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm funny, I swear I saw this page using the getIngest API somewhere...

Hmm It actually does... don't know what's the difference between the 2
https://github.com/livepeer/livepeer-com/blob/1c9390d3490f6f7473d770d967c672599b3e7d51/packages/www/pages/app/stream/%5Bid%5D.tsx#L281

packages/www/pages/app/stream/[id].tsx Show resolved Hide resolved
@iameli iameli merged commit 438df64 into master Apr 12, 2022
@iameli iameli deleted the gio/switch-cdn branch April 12, 2022 16:43
@iameli iameli restored the gio/switch-cdn branch April 12, 2022 16:43
@hjpotter92 hjpotter92 deleted the gio/switch-cdn branch September 20, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants