Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions: fix Docker build globbing #1030

Merged
merged 2 commits into from
Apr 29, 2022
Merged

github actions: fix Docker build globbing #1030

merged 2 commits into from
Apr 29, 2022

Conversation

iameli
Copy link
Member

@iameli iameli commented Apr 29, 2022

Lil fix to the Docker image builds

@iameli iameli requested a review from hjpotter92 April 29, 2022 21:38
@iameli iameli requested a review from a team as a code owner April 29, 2022 21:38
@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 9:53PM (UTC)

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -12,7 +12,7 @@
"docs-positions": "node ./generate-docs-positions.js",
"docker:build": "docker build $(printf ' -t livepeerci/www:%s' ${DOCKER_TAGS:-master}) -f Dockerfile ../..",
"docker:push": "for TAG in ${DOCKER_TAGS:-dev}; do docker push livepeerci/www:${TAG}; done",
"pkg": "pkg --out-path=bin --no-bytecode --public-packages \"*\" --public . --compress GZip",
"pkg": "pkg --out-path=bin --no-bytecode --public-packages \"*\" --public . --compress GZip ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can revert the 2nd commit i guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after i get a clean master build i guess

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o tru

@iameli iameli merged commit 9b437dc into master Apr 29, 2022
@iameli iameli deleted the eli/route-globbing branch April 29, 2022 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants