Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest design-system library #1032

Merged
merged 21 commits into from
May 10, 2022
Merged

Use latest design-system library #1032

merged 21 commits into from
May 10, 2022

Conversation

adamsoffer
Copy link
Member

What does this pull request do? Explain your changes. (required)
This PR removes the design system package in the mono repo and replaces it with the published @livepeer/design-system npm package.

@adamsoffer adamsoffer requested a review from a team as a code owner April 30, 2022 21:46
@vercel
Copy link

vercel bot commented Apr 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview May 10, 2022 at 11:13PM (UTC)

onCheckedChange={(e) =>
setIsCopyrightInfringiment(e.target.checked)
onCheckedChange={(checked) =>
setIsCopyrightInfringiment(checked == true ? true : false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check looks redundant?

Copy link
Member Author

@adamsoffer adamsoffer May 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. It was a lazy attempt at avoiding a weird typescript warning. Just fixed by explicitly setting the type on the function parameter.

@adamsoffer adamsoffer merged commit 6c61ca7 into master May 10, 2022
@adamsoffer adamsoffer deleted the as/ds-refactor branch May 10, 2022 23:14
victorges added a commit that referenced this pull request May 18, 2022
This fixes a regression caused by: #1032

Turns out we are mixing @theme-ui/components with the
@livepeer/design-system in that page.

We should probably migrate everything to design system
altogether, but while we don't do that let's keep it
working as before.
adamsoffer pushed a commit that referenced this pull request May 18, 2022
This fixes a regression caused by: #1032

Turns out we are mixing @theme-ui/components with the
@livepeer/design-system in that page.

We should probably migrate everything to design system
altogether, but while we don't do that let's keep it
working as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants