Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/admin: Allow content moderation from a single page #1067

Merged
merged 8 commits into from
May 19, 2022

Conversation

victorges
Copy link
Member

@victorges victorges commented May 18, 2022

What does this pull request do? Explain your changes. (required)

This is to make it easier to inspect a given running stream and nuking (suspending) the user.

It allows all that to be done from the same stream detail page, by having an embedded player in
there and adding a button to suspend the user. Additionally, page can now be opened with the
playback ID of the stream, making it easier to go from alert to moderation page (alerts can even
link to it directly).

Specific updates (required)

  • Create separate "SuspendUserModal" component to be reused
  • Created suspend user button in the bottom of page
  • Stream detail page made addressable by playback ID
  • Added embedded player in the page to check the content (autoplay off by default, can enable on querystring)

-

  • How did you test each of these updates (required)
    Open stream detail page and check player works, check suspending the user works.

Does this pull request close any open issues?
No.

Screenshots (optional):
Screen Shot 2022-05-18 at 20 14 18

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented May 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview May 18, 2022 at 11:20PM (UTC)

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1067 (6c05d42) into master (beb26cd) will increase coverage by 0.02289%.
The diff coverage is 0.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1067         +/-   ##
===================================================
+ Coverage   46.11759%   46.14048%   +0.02288%     
===================================================
  Files             64          64                 
  Lines           4031        4029          -2     
  Branches         679         679                 
===================================================
  Hits            1859        1859                 
+ Misses          1973        1971          -2     
  Partials         199         199                 
Impacted Files Coverage Δ
packages/api/src/controllers/user.ts 40.99379% <0.00000%> (+0.25304%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb26cd...6c05d42. Read the comment docs.

@victorges victorges changed the title Vg/feat/admin stream full mod www/admin: Allow content moderation from a single page May 18, 2022
@victorges victorges marked this pull request as ready for review May 18, 2022 23:15
@victorges victorges requested a review from a team as a code owner May 18, 2022 23:15
It is enough to just suspend the user, which will already make
all streams effectively suspended, but only terminate the streams
instead of marking them as suspended as well.

This allows us to potentially revert the suspension more easily,
by not changing the state of every stream in the user account.
Copy link
Member

@iameli iameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@victorges victorges merged commit 42ed0b5 into master May 19, 2022
@victorges victorges deleted the vg/feat/admin-stream-full-mod branch May 19, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants