-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: New API to get playback URL from an identifier #1075
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3b6254d
to
bf54844
Compare
Codecov Report
@@ Coverage Diff @@
## master #1075 +/- ##
===================================================
+ Coverage 45.68115% 49.60995% +3.92879%
===================================================
Files 64 66 +2
Lines 4052 4102 +50
Branches 708 690 -18
===================================================
+ Hits 1851 2035 +184
+ Misses 1987 1839 -148
- Partials 214 228 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks tests!
Also allow it to be used without modifying the input (ever!)
bf54844
to
c417d6b
Compare
What does this pull request do? Explain your changes. (required)
This creates an API to facilitate and create a consistent interface for creating a playback URL
given an identifier. It could be either a stream or asset playback ID, or also a recorded session
ID and it will return a response in the same format containing the corresponding HLS playback URL.
The context for this is the creation of the Lens publication video NFTs with an embeddable HLS player.
Ideally the NFT would have no internal identifiers from livepeer.com, maybe referencing assets by their
CIDs instead. While we don't do that, we can at least simplify that internal identifier and only provide a
playback ID (additionally from the CID of the original file). The playback ID will be used to playback
a pre-processed version of the video in an optimized format.
Having this API also makes these NFTs future-proof, since we will be able to change their format without
it breaking every previously minted NFT that had the broken references. The reference will be only a simple
playback ID and we can change the response of that API freely.
This also has a soft dependency on #1051 but they can be deployed independently. It's also based on top of
#1014 but I believe it can also be rebased, no strict dependencies in the code.
Specific updates (required)
-
yarn test
✨Does this pull request close any open issues?
Implements #1058
Checklist: