Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split trusted/untrusted across all nodes, rather than within a region #1083

Merged
merged 1 commit into from
May 24, 2022

Conversation

thomshutt
Copy link
Contributor

@thomshutt thomshutt commented May 24, 2022

What does this pull request do? Explain your changes. (required)

Follow-on PR from #1064. That PR marks 50% of Os within a region as untrusted, but the actual desired behaviour was an overall 50/50 split.

Specific updates (required)

-

How did you test each of these updates (required)

Deployed to Staging and hit the /region API endpoint to test

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview May 24, 2022 at 4:00PM (UTC)

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1083 (5b0d3c8) into master (ca0b25f) will increase coverage by 0.01337%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1083         +/-   ##
===================================================
+ Coverage   46.14048%   46.15385%   +0.01337%     
===================================================
  Files             64          64                 
  Lines           4029        4030          +1     
  Branches         679         679                 
===================================================
+ Hits            1859        1860          +1     
  Misses          1971        1971                 
  Partials         199         199                 
Impacted Files Coverage Δ
packages/api/src/controllers/region.js 75.00000% <100.00000%> (+0.92592%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0b25f...5b0d3c8. Read the comment docs.

@thomshutt thomshutt marked this pull request as ready for review May 24, 2022 16:40
@thomshutt thomshutt requested a review from a team as a code owner May 24, 2022 16:40
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomshutt thomshutt merged commit 76f26c5 into master May 24, 2022
@thomshutt thomshutt deleted the half-all-untrusted branch May 24, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants