Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Allow patching asset's meta field #1095

Merged
merged 2 commits into from
May 31, 2022
Merged

api: Allow patching asset's meta field #1095

merged 2 commits into from
May 31, 2022

Conversation

victorges
Copy link
Member

@victorges victorges commented May 31, 2022 •
edited

Implements #1090

@victorges victorges requested a review from a team as a code owner May 31, 2022 16:31
@vercel
Copy link

vercel bot commented May 31, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview May 31, 2022 at 5:02PM (UTC)

@codecov
Copy link

codecov bot commented May 31, 2022 •
edited

Codecov Report

Merging #1095 (f118b57) into master (e1be14a) will increase coverage by 0.02463%.
The diff coverage is 66.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1095         +/-   ##
===================================================
+ Coverage   49.19942%   49.22405%   +0.02462%     
===================================================
  Files             66          66                 
  Lines           4122        4124          +2     
  Branches         724         724                 
===================================================
+ Hits            2028        2030          +2     
  Misses          1851        1851                 
  Partials         243         243
Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 36.88889% <66.66667%> (+0.56602%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1be14a...f118b57. Read the comment docs.

gioelecerati
gioelecerati approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gioelecerati
gioelecerati approved these changes May 31, 2022
View reviewed changes
packages/api/src/controllers/asset.ts
@@ -576,6 +580,7 @@ app.patch(
async (req, res) => {
// these are the only updateable fields
let { name, meta, storage } = req.body as AssetPatchPayload;
validateAssetMeta(meta);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@victorges victorges merged commit 5849371 into master May 31, 2022
@victorges victorges deleted the vg/feat/edit-meta branch May 31, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioelecerati gioelecerati gioelecerati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@victorges @gioelecerati