Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Webhooks for VOD #1099

Merged
merged 9 commits into from
Jun 7, 2022
Merged

api: Webhooks for VOD #1099

merged 9 commits into from
Jun 7, 2022

Conversation

victorges
Copy link
Member

@victorges victorges commented Jun 3, 2022

What does this pull request do? Explain your changes. (required)

This implements a couple of webhooks for the VOD feature in general, as
per this short discussion/spec.

Specific updates (required)

  • New event types for webhooks
  • Webhooks for tasks
  • Webhooks for assets

-

  • How did you test each of these updates (required)
    yarn test (might write some explicit tests for these, idk)

Does this pull request close any open issues?
Implements #1005

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Jun 3, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-com ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 6:43PM (UTC)
livepeer-studio-docs ❌ Failed (Inspect) Jun 7, 2022 at 6:43PM (UTC)

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1099 (b61fe67) into master (0de08c9) will increase coverage by 0.20327%.
The diff coverage is 75.67568%.

❗ Current head b61fe67 differs from pull request most recent head 743649c. Consider uploading reports for the commit 743649c to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1099         +/-   ##
===================================================
+ Coverage   50.21750%   50.42077%   +0.20326%     
===================================================
  Files             66          66                 
  Lines           4138        4159         +21     
  Branches         730         733          +3     
===================================================
+ Hits            2078        2097         +19     
- Misses          1814        1815          +1     
- Partials         246         247          +1     
Impacted Files Coverage Δ
packages/api/src/controllers/task.ts 13.26531% <0.00000%> (ø)
packages/api/src/webhooks/cannon.ts 47.95322% <0.00000%> (ø)
packages/api/src/controllers/asset.ts 46.49123% <75.00000%> (+0.71345%) ⬆️
packages/api/src/task/scheduler.ts 51.80723% <81.48148%> (+10.26876%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0de08c9...743649c. Read the comment docs.

@victorges victorges marked this pull request as ready for review June 4, 2022 00:17
@victorges victorges requested a review from a team as a code owner June 4, 2022 00:17
@victorges
Copy link
Member Author

PR description that Github is not showing:

@victorges
Copy link
Member Author

Aha! The PR template apparently came with a big comment that wasn't closed, then everything was hidden lol

Fixed now

Copy link
Contributor

@figintern figintern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Webhook logic LGTM, just some nits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants