Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename livepeer/livepeer-studio to livepeer/studio #1144

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

victorges
Copy link
Member

Just a find all & replace. Avoids the repetition cacophony.

Just a find all & replace. Avoids the repetition cacophony.
@vercel
Copy link

vercel bot commented Jul 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Jul 6, 2022 at 6:40PM (UTC)

@hjpotter92
Copy link
Member

needs updates in package.json

@victorges
Copy link
Member Author

@hjpotter92 Done! Weird that the package.json was pointing to a livepeer/livepeer.studio repository which I think never existed (or at least github is not redirecting anymore).

The package is still named livepeer.studio and I think we can keep it like this tho, or we can change to @livepeer/studio in the future. I'm not so sure about the implications there tho, so rather leave it as is.

Copy link
Member

@hjpotter92 hjpotter92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjpotter92 Done! Weird that the package.json was pointing to a livepeer/livepeer.studio repository which I think never existed (or at least github is not redirecting anymore).

That might be because the last find-and-replace might've taken place using regex (instead of exact match), so livepeer.com matched livepeer-com. 🤔

The package is still named livepeer.studio and I think we can keep it like this tho, or we can change to @livepeer/studio in the future. I'm not so sure about the implications there tho, so rather leave it as is.

lgtm!

@victorges victorges merged commit 6514856 into master Jul 7, 2022
@victorges victorges deleted the vg/chore/rebrand branch July 7, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants