-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Allow finding an asset by CID (of video or metadata) #1153
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## master #1153 +/- ##
===================================================
+ Coverage 50.42057% 50.50408% +0.08351%
===================================================
Files 66 66
Lines 4161 4166 +5
Branches 735 736 +1
===================================================
+ Hits 2098 2104 +6
Misses 1816 1816
+ Partials 247 246 -1
Continue to review full report at Codecov.
|
ae967da
to
f7ffc32
Compare
525b419
to
34ec554
Compare
116cab3
to
34ec554
Compare
Also remove the helper which is not making things clearer
Tasks had some weird cross-dependency with the assets and then resulted in additional indexes on that table. To simplify things, let's only support it for assets right now which is where we really need it.
just some cleanup
6204636
to
487cba4
Compare
What does this pull request do? Explain your changes. (required)
This is to allow finding an asset from its CID (of video or metadata).
It will allow clean-up of pins in any IPFS provider, so that we only actually delete
the Pin when there are no more assets pointing to that same file.
Will also allow unpinning of previous metadata when the NFT metadata changes,
following that same principle/api.
Specific updates (required)
/asset
API-
yarn test
Does this pull request close any open issues?
Not really, but it's related to the current Piñata incident that we're having. Gotta create an issue for that.
Checklist: