vod: New webhooks & simplified asset responses

[gioelecerati]

What does this pull request do? Explain your changes. (required)

Rename the task.created webhook to task.spawned, simplify the asset responses

Specific updates (required)

• Generating a signed url now responds only the ID of the task instead of the full task object
• The /api/asset endpoint returns the asset object without the videoSpec field
• The same endpoint returns the videoSpec if details=true is passed.
• task.created -> task.spawned webhook. createTask -> spawnTask in TaskScheduler
• Implement webhooks as Simpler webhooks for VOD #1148
• Integrate docs: fixed the response spec of the asset upload #1136
• Change the docs accordingly to the new responses, webhooks and request params

How did you test each of these updates (required)

yarn test

Does this pull request close any open issues?

Fixes #1148
Fixes #1149

Screenshots (optional):

Checklist:

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
livepeer-studio	✅ Ready (Inspect)	Visit Preview	Aug 15, 2022 at 4:44PM (UTC)

[codecov]

Codecov Report

Merging #1154 (a7aa7cc) into master (17134a1) will decrease coverage by 0.06312%.
The diff coverage is 44.82759%.

@@                 Coverage Diff                 @@
##              master       #1154         +/-   ##
===================================================
- Coverage   51.47778%   51.41466%   -0.06313%     
===================================================
  Files             66          66                 
  Lines           4297        4312         +15     
  Branches         767         771          +4     
===================================================
+ Hits            2212        2217          +5     
- Misses          1816        1823          +7     
- Partials         269         272          +3     

Impacted Files	Coverage Δ
packages/api/src/store/queue.ts	78.18182% <ø> (ø)
packages/api/src/controllers/asset.ts	55.19481% <41.66667%> (-0.25074%)	⬇️
packages/api/src/task/scheduler.ts	46.60194% <47.05882%> (-1.78516%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17134a1...a7aa7cc. Read the comment docs.

Impacted Files	Coverage Δ
packages/api/src/store/queue.ts	78.18182% <ø> (ø)
packages/api/src/controllers/asset.ts	55.19481% <41.66667%> (-0.25074%)	⬇️
packages/api/src/task/scheduler.ts	46.60194% <47.05882%> (-1.78516%)	⬇️

[victorges]

LGTM with a few changes, but most are nits (which are always optional)

[victorges]

Some required, functional, changes are still pending.
Please fix and let me know for a new review.

[victorges]

LGTM!

[victorges]

lets merge this

[victorges]

@gioelecerati after merging some stuff to master that added conflicts on this, I've just rebased this one to master myself. Included 2 changes apart from that:

• Fixed a regression that was calling db.asset.delete instead of markDeleted: bc56864#diff-72488d88e2bc58582e64d3c8e8283bcfb59c422a35fcf476d51a2e1da9e41716R305
• Improve the mung middleware changes (I had refactored it in another PR so there was a much clearer integration path there). Also made details automatically true for admins 😎 47738a9
• Also a fix on the updateAsset func as it would always send a webhook for "ready" or "failed" assets. It should only do so when there is actually a change in the phase: a7aa7cc

[victorges]

LGTM! Let's launch this

[victorges]

👀