Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Fix VOD events by making streamId optional #1161

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

Fixes VOD webhooks since they don't have a streamId and the WebhookCannon code required it to be present.

Specific updates (required)

Make streamId optional in WebhookCannon code.

-

  • How did you test each of these updates (required)

yarn test

Does this pull request close any open issues?

No.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner July 15, 2022 21:41
@vercel
Copy link

vercel bot commented Jul 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Jul 15, 2022 at 9:42PM (UTC)

@victorges victorges merged commit 52fdf68 into master Jul 15, 2022
@victorges victorges deleted the vg/fix/vod-webhooks branch July 15, 2022 21:51
@Shih-Yu Shih-Yu mentioned this pull request Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants