Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix On Demand PATCH API making storage property optional #1173

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

Shih-Yu
Copy link
Collaborator

@Shih-Yu Shih-Yu commented Jul 19, 2022

What does this pull request do? Explain your changes. (required)

Fixed updating the asset for On Demand so that the storage property is optional.

Specific updates (required)

Make storage optional when calling the storageUpdates function

-

How did you test each of these updates (required)
yarn test

Does this pull request close any open issues?

Yes - #1172

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@Shih-Yu Shih-Yu requested a review from victorges July 19, 2022 22:20
@Shih-Yu Shih-Yu requested a review from a team as a code owner July 19, 2022 22:20
@Shih-Yu Shih-Yu linked an issue Jul 19, 2022 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Jul 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Jul 19, 2022 at 10:21PM (UTC)

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Congrats on your first code contribution 🥳

@victorges victorges merged commit 7f70c43 into master Jul 26, 2022
@victorges victorges deleted the sh/fix/vod-patch-api branch July 26, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix On Demand API PATCH to make storage property optional
2 participants