Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Rename /import to /upload/url #1182

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Conversation

victorges
Copy link
Member

We renamed the concept and should rename the APIs accordingly.

@victorges victorges requested a review from a team as a code owner August 1, 2022 22:24
@vercel
Copy link

vercel bot commented Aug 1, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 10:30PM (UTC)

Less confusion between /upload/:url and /upload/url

Also notice we don't reeeally need backward compatibility:
Old pre-signed URLs will break, but any new URL will work again.
@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1182 (b0a4895) into master (7d4f42e) will decrease coverage by 0.09628%.
The diff coverage is 33.33333%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1182         +/-   ##
===================================================
- Coverage   50.39654%   50.30026%   -0.09629%     
===================================================
  Files             66          66                 
  Lines           4161        4163          +2     
  Branches         736         736                 
===================================================
- Hits            2097        2094          -3     
- Misses          1816        1821          +5     
  Partials         248         248                 
Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 44.34783% <33.33333%> (-1.70480%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d4f42e...b0a4895. Read the comment docs.

@victorges victorges merged commit 62ac698 into master Aug 2, 2022
@victorges victorges deleted the vg/feat/upload-url-endpoint branch August 2, 2022 14:16
Copy link
Collaborator

@Shih-Yu Shih-Yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants