Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions to start the RabbitMQ container #1198

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

clacladev
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
I added the instructions to start the RabbitMQ container when starting the /api package locally.

Specific updates (required)

In the package/api/README.md I added a few line to start the RabbitMQ docker image.

-

  • How did you test each of these updates (required)

Before, I was receiving an error the the RabbitMQ container was not replying when starting the package with yarn dev. Then when I started manually the RabbitMQ container, the error disappeared. The www package also was able to run properly and I was able to register a new user.

Does this pull request close any open issues?

No

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@clacladev clacladev requested a review from a team as a code owner August 11, 2022 15:58
@vercel
Copy link

vercel bot commented Aug 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 3:59PM (UTC)

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adamsoffer adamsoffer merged commit c28b572 into master Aug 11, 2022
@adamsoffer adamsoffer deleted the api-setup-instructions branch August 11, 2022 16:40
@clacladev
Copy link
Contributor Author

Great! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants