-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add VOD detail page #1199
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I found what it is! After #1154, we started hiding some details info from the So to fix this, you need to add |
Moving TODOs from #1194 to this PR since this is a superset of it:
|
Codecov Report
@@ Coverage Diff @@
## master #1199 +/- ##
===================================================
+ Coverage 51.39884% 51.47093% +0.07209%
===================================================
Files 66 66
Lines 4325 4317 -8
Branches 777 774 -3
===================================================
- Hits 2223 2222 -1
+ Misses 1825 1820 -5
+ Partials 277 275 -2
Continue to review full report at Codecov.
|
@adamsoffer @victorges @iameli thanks for the review, made those changes requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this pull request do? Explain your changes. (required)
Adds VOD detail page.
Does this pull request close any open issues?
Fixes #1026
Fixes #1027
Fixes #1028
Closes #1024