api: FIx object store URL parsing #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some minimum validation
Also remove log
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
changed the title
Easier than doing that on the DB
gioelecerati
approved these changes
Aug 23, 2022
| @@ -45,7 +45,7 @@ describe("controllers/playback", () => { | |||
| beforeEach(async () => { | |||
| await db.objectStore.create({ | |||
| id: "mock_vod_store", | |||
| url: "http://user:password@localhost:8080/us-east-1/vod", | |||
| url: "s3+http://user:password@localhost:8080/us-east-1/vod", | |||
Codecov Report
@@ Coverage Diff @@
## master #1228 +/- ##
===================================================
+ Coverage 51.39369% 51.54307% +0.14938%
===================================================
Files 66 66
Lines 4341 4342 +1
Branches 781 783 +2
===================================================
+ Hits 2231 2238 +7
+ Misses 1830 1825 -5
+ Partials 280 279 -1
Continue to review full report at Codecov.
|
That was hiding a bug
|
All good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes the API logic for parsing Object Store URLs, currently used only for the
VOD APIs for uploading files (both
directandtus).The fix is necessary because the Go library for parsing these URLs changed
in an incompatible way for the Catalyst VOD work to flow through. Specifically, it does
not support having regions in the URLs anymore because it now supports specifying a path
prefix after the bucket name.
Specific updates (required)
-
yarn testDoes this pull request close any open issues?
Implements #1205
Checklist: