api: Propagate progress field to asset #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add processing phase to assets so one doesn't have to use the existence of the progress field to tell if it has started or not.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
commented
Sep 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #1244 +/- ##
===================================================
- Coverage 51.37552% 51.29439% -0.08114%
===================================================
Files 66 66
Lines 4362 4365 +3
Branches 791 794 +3
===================================================
- Hits 2241 2239 -2
- Misses 1838 1842 +4
- Partials 283 284 +1
Continue to review full report at Codecov.
|
Stop merging hell. Only the retries field had to be copied around over and over, which is better than clearing the progress and step anyway.
gioelecerati
approved these changes
Sep 6, 2022
victorges
force-pushed
the
vg/feat/asset-progress
branch
from
0727a4d
to
2d9f567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Also add processing phase to assets so one doesn't have
to use the existence of the progress field to tell if it
has started or not.
Specific updates (required)
progressfield to assetsprocessingphase to assets-
yarn testDoes this pull request close any open issues?
Unofficial issue discussed yesterday for SDK to unblock livepeer/ui-kit#27
Checklist: