Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Remove asset schema migration compatibility code #1247

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This removes a compatibility code that I created for migrating assets to the new
schema a month ago on #1178.

With this, we delete 255 of tech debt to keep the code simpler. All assets have already been migrated
to the new format through the /migrate-status API, both in staging and in prod. This is given by this
response on the /migrate-status API on both of them:

{
    "count": 0,
    "nextCursor": null,
    "updated": []
}

Specific updates (required)

  • Remove /migrate-status API
  • Remove custom DB table with migration tricks
  • Remove migration tests

-

  • How did you test each of these updates (required)
    yarn test

Does this pull request close any open issues?
Kills unticketed tech debt.

Screenshots (optional):
Screen Shot 2022-09-05 at 14 46 23

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added removed tests to cover my changes.

@victorges victorges requested a review from a team as a code owner September 5, 2022 17:46
@vercel
Copy link

vercel bot commented Sep 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 7, 2022 at 8:36PM (UTC)

Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from vg/feat/asset-progress to master September 7, 2022 20:32
@victorges victorges merged commit 24975e7 into master Sep 7, 2022
@victorges victorges deleted the vg/chore/remove-compat-api branch September 7, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants