Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website UX fixes #1266

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Website UX fixes #1266

merged 5 commits into from
Sep 12, 2022

Conversation

clacladev
Copy link
Contributor

@clacladev clacladev commented Sep 12, 2022

What does this pull request do? Explain your changes. (required)
Addressed a series of UX issues on Dashboard part of the app.

Specific updates (required)

  • Fixes the rounded corners issue described here
  • On https://livepeer.studio/dashboard, under the "Create your own live stream", where it says "like OBS Studio or streamlabs. Here’s how.", there should be a colon after "here's how:"
  • On all dashboard pages, links/button use blue text, but so do some of the headings. Can we use different colors to make it clear what’s clickable and what’s not? (If the brand guide / design allows it.)
  • On https://livepeer.studio/dashboard/assets, the "Learn more -->" button leads to a 404.
    Same thing for the other Docs links on the main dashboard page,
  • On https://livepeer.studio/dashboard/assets, "Upload your first Video on Demand asset" should become "Upload your first On Demand asset", to align with the feature's brand.
  • On https://livepeer.studio/dashboard/assets, "Video on Demand" shouldn't be capitalized, because it's describing the On Demand feature, which is capitalized because it's a branded feature term. The same is true for video on demand vs On Demand elsewhere on the dashboard or docs.

-

  • How did you test each of these updates (required)

Before and after making the change I took a screenshot of the element affected and manually testing with Light and Dark mode.

Does this pull request close any open issues?

Fixes #1255

Screenshots (optional):

Asset (before, after light, after dark)

asset before
asset after light
asset after dark

Billing (before, after light, after dark)

billing before
billing after light
billing after dark

Help (before, after light, after dark)

help before
help after light
help after dark

### Multistream dialog (before, after light, after dark)
multistream dialog before
multistream dialog after light
multistream dialog after dark

Stream (before, after light, after dark)

stream before
stream after light
stream after dark

Usage (before, after light, after dark)

usage before
usage after light
usage after dark

@vercel
Copy link

vercel bot commented Sep 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 12, 2022 at 3:48PM (UTC)

@clacladev
Copy link
Contributor Author

Here the video player corner radius fix

Before
Screenshot 2022-09-12 at 16 51 13

After
Screenshot 2022-09-12 at 16 49 04

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @clacladev :shipit:

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1266 (372f5bc) into master (1794bd9) will increase coverage by 0.09236%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1266         +/-   ##
===================================================
+ Coverage   51.11983%   51.21219%   +0.09235%     
===================================================
  Files             66          66                 
  Lines           4331        4331                 
  Branches         785         785                 
===================================================
+ Hits            2214        2218          +4     
+ Misses          1838        1835          -3     
+ Partials         279         278          -1     
Impacted Files Coverage Δ
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1794bd9...372f5bc. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

@adamsoffer adamsoffer merged commit 4407b92 into master Sep 12, 2022
@adamsoffer adamsoffer deleted the clacladev/#1255-website-ux-fixes branch September 12, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard website UX issues
2 participants