Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Implement progressive catalysis #1273

Merged
merged 4 commits into from
Sep 23, 2022

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This is to allow migrating only partially to the new Catalyst pipeline, by providing a "gradual rollout percent"
flag on the command line used when creating new assets to randomly select a % of assets to go through
the new flow.

Specific updates (required)

  • Create the flag
  • Use it
  • Update the API schema to add upload task type officially

-

  • How did you test each of these updates (required)
    yarn test

Does this pull request close any open issues?
Implements #1269

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner September 13, 2022 20:45
@vercel
Copy link

vercel bot commented Sep 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 7:27PM (UTC)

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1273 (57d8521) into master (24f512e) will increase coverage by 0.02369%.
The diff coverage is 33.33333%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1273         +/-   ##
===================================================
+ Coverage   51.28146%   51.30515%   +0.02368%     
===================================================
  Files             66          66                 
  Lines           4331        4329          -2     
  Branches         802         803          +1     
===================================================
  Hits            2221        2221                 
+ Misses          1829        1826          -3     
- Partials         281         282          +1     
Impacted Files Coverage Δ
packages/api/src/parse-cli.ts 31.70732% <ø> (ø)
packages/api/src/controllers/asset.ts 55.13699% <33.33333%> (+0.37509%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f512e...57d8521. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/parse-cli.ts 31.70732% <ø> (ø)
packages/api/src/controllers/asset.ts 55.13699% <33.33333%> (+0.37509%) ⬆️

Copy link
Member

@gioelecerati gioelecerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 1c297b4 into master Sep 23, 2022
@victorges victorges deleted the vg/feat/catalyst-gradual-rollout branch September 23, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants