-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFS export date #1277
IPFS export date #1277
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@adamsoffer My implementation differs from the design in the how the date is formatted. In the end I went for the format that is already being used throughout the interface and in the same page. To keep consistency. In case it's not ok, let's discuss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think the field should be renamed to updatedAt
and either also set on the nftMetadata
or removed from its schema.
packages/www/components/Dashboard/AssetDetails/AssetOverviewTab.tsx
Outdated
Show resolved
Hide resolved
@victorges I made the updates to the name. I would ask you gently to review I did the right changes to the schemas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
bd36de7
to
b4049e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #1277 +/- ##
===================================================
+ Coverage 51.06138% 51.15367% +0.09228%
===================================================
Files 66 66
Lines 4334 4334
Branches 786 786
===================================================
+ Hits 2213 2217 +4
+ Misses 1842 1839 -3
+ Partials 279 278 -1
Continue to review full report at Codecov.
|
What does this pull request do? Explain your changes. (required)
Added the IPFS export date to the Asset page.
Specific updates (required)
createdAt
property to theasset.storage.ipfs
object in schemasHow did you test each of these updates (required)
Simulating locally the date being present.
Does this pull request close any open issues?
Fixes #1253
Screenshots (optional):