Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFS export date #1277

Merged
merged 6 commits into from
Sep 16, 2022
Merged

IPFS export date #1277

merged 6 commits into from
Sep 16, 2022

Conversation

clacladev
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Added the IPFS export date to the Asset page.

Specific updates (required)

  • Added createdAt property to the asset.storage.ipfs object in schemas
  • If present, shows the formatted date in the IPFS storage box in the Asset page

How did you test each of these updates (required)
Simulating locally the date being present.

Does this pull request close any open issues?
Fixes #1253

Screenshots (optional):
Screenshot 2022-09-15 at 12 37 48

Screenshot 2022-09-15 at 12 37 56

@clacladev clacladev requested a review from a team as a code owner September 15, 2022 11:42
@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 16, 2022 at 10:34AM (UTC)

@clacladev
Copy link
Contributor Author

Tested in staging successfully
Screenshot 2022-09-15 at 16 17 52

@clacladev
Copy link
Contributor Author

@adamsoffer My implementation differs from the design in the how the date is formatted. In the end I went for the format that is already being used throughout the interface and in the same page. To keep consistency. In case it's not ok, let's discuss.

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think the field should be renamed to updatedAt and either also set on the nftMetadata or removed from its schema.

packages/api/src/schema/schema.yaml Outdated Show resolved Hide resolved
packages/api/src/task/scheduler.ts Outdated Show resolved Hide resolved
@clacladev
Copy link
Contributor Author

@victorges I made the updates to the name. I would ask you gently to review I did the right changes to the schemas

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1277 (056cf86) into master (25b49e4) will increase coverage by 0.09229%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1277         +/-   ##
===================================================
+ Coverage   51.06138%   51.15367%   +0.09228%     
===================================================
  Files             66          66                 
  Lines           4334        4334                 
  Branches         786         786                 
===================================================
+ Hits            2213        2217          +4     
+ Misses          1842        1839          -3     
+ Partials         279         278          -1     
Impacted Files Coverage Δ
packages/api/src/task/scheduler.ts 43.22034% <ø> (ø)
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b49e4...056cf86. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/task/scheduler.ts 43.22034% <ø> (ø)
packages/api/src/webhooks/cannon.ts 49.70760% <0.00000%> (+2.33917%) ⬆️

@clacladev clacladev merged commit 5d2c3fc into master Sep 16, 2022
@clacladev clacladev deleted the clacladev/ipfs-export-date branch September 16, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add upload date to IPFS integration component
2 participants