Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www: Fix asset details page viewership components #1291

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This is to fix the frontend for the viewership API, which broke after the last change,
but more importantly than that, shouldn't break the asset detail page anyhow.

Specific updates (required)

  • Make views an optional component in the page, only if available
  • Fetch views by asset ID instead of playback ID

-

  • How did you test each of these updates (required)
    Access viewership page and ensure it works again.

Does this pull request close any open issues?
Fixes issue just found on deploy.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner September 19, 2022 20:29
@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 9:09PM (UTC)

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants