Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-control: fix suspended check #1325

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

Fix user.suspended and content.suspended check

Specific updates (required)

-

  • How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner October 4, 2022 00:40
@vercel
Copy link

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Oct 4, 2022 at 0:43AM (UTC)

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #1325 (f64e978) into master (cb508ed) will increase coverage by 0.25683%.
The diff coverage is 85.29412%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1325         +/-   ##
===================================================
+ Coverage   51.60416%   51.86099%   +0.25683%     
===================================================
  Files             68          68                 
  Lines           4426        4460         +34     
  Branches         822         833         +11     
===================================================
+ Hits            2284        2313         +29     
- Misses          1849        1851          +2     
- Partials         293         296          +3     
Impacted Files Coverage Δ
packages/api/src/controllers/signing-key.ts 60.67416% <ø> (ø)
packages/api/src/controllers/access-control.ts 86.48649% <84.84848%> (-13.51351%) ⬇️
packages/api/src/middleware/tracking.ts 81.81818% <100.00000%> (+0.86579%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc91dd7...f64e978. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/signing-key.ts 60.67416% <ø> (ø)
packages/api/src/controllers/access-control.ts 86.48649% <84.84848%> (-13.51351%) ⬇️
packages/api/src/middleware/tracking.ts 81.81818% <100.00000%> (+0.86579%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gioelecerati gioelecerati merged commit e66fe29 into master Oct 4, 2022
@gioelecerati gioelecerati deleted the gio/fix/acl-suspended branch October 4, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants