-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Showing progress in the Assets list and details page #1326
Conversation
Added the processing progress
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ladev/progress-asset
Codecov Report
@@ Coverage Diff @@
## master #1326 +/- ##
===================================================
- Coverage 51.95067% 51.86099% -0.08969%
===================================================
Files 68 68
Lines 4460 4460
Branches 833 833
===================================================
- Hits 2317 2313 -4
- Misses 1848 1851 +3
- Partials 295 296 +1
Continue to review full report at Codecov.
|
Addressing @victorges review, published erroneously on this other PR #1330 (confusion issue is my fault).
Regarding the current UX of moving between Uploading to Processing The Assets list page has also a refresh interval of 15s. That's why it is jumping from FYI, if you start to upload a video and, while it has not finished yet, you tap on it you will see it opening inthe Asset details page still uploading. This one will refresh the asset details every 5s. So you will see a smoother process "uploading -> processing" I don't know why the refresh intervals are different, but I supposed that's because the two calls are not expensive the same. Regarding the progress smoothing |
@clacladev All makes sense! Yeah I don't think the progress smoothing is a priority, only if it was easy enough to implement for a cleaner UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/www/components/Dashboard/AssetDetails/AssetPlayerBox/ProcessingProgress.tsx
Show resolved
Hide resolved
packages/www/components/Dashboard/AssetDetails/AssetPlayerBox/Progress.tsx
Outdated
Show resolved
Hide resolved
…Progress.tsx Better managing the UI text when progress percentage is zero Co-authored-by: Victor Elias <victorgelias@gmail.com>
What does this pull request do? Explain your changes. (required)
Add the file upload progress and processing progress to the Assets list and Asset details page.
Specific updates (required)
How did you test each of these updates (required)
I extensively tested the feature with the different themes.
Does this pull request close any open issues?
Fixes #1297
Screenshots (optional):