-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add isTestUser flag #1329
api: add isTestUser flag #1329
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/api/src/schema/schema.yaml
Outdated
isTestUser: | ||
type: boolean | ||
example: false | ||
description: User creates test streams and playbackIds should be flagged as such |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the idea to set these directly on the DB? I'm fine with that actually, but could you also add an internal
boolean field here? I created that so @ecmulli could filter out internal Livepeer users from the usage queries (not always we use our @livepeer.org emails lol).
Since you're adding this here, might as well add that other one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Codecov Report
@@ Coverage Diff @@
## master #1329 +/- ##
===================================================
- Coverage 51.95067% 51.88256% -0.06812%
===================================================
Files 68 68
Lines 4460 4462 +2
Branches 833 834 +1
===================================================
- Hits 2317 2315 -2
- Misses 1848 1851 +3
- Partials 295 296 +1
Continue to review full report at Codecov.
|
Useful for filtering test streams out of Prometheus data and not much else.