Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-control: make /gate public #1334

Merged
merged 2 commits into from
Oct 7, 2022
Merged

access-control: make /gate public #1334

merged 2 commits into from
Oct 7, 2022

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Oct 7, 2022

What does this pull request do? Explain your changes. (required)

Make the gate api public

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner October 7, 2022 15:57
@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Oct 7, 2022 at 4:15PM (UTC)

@codecov
Copy link

codecov bot commented Oct 7, 2022

Codecov Report

Merging #1334 (23d2dca) into master (2d36972) will increase coverage by 0.02156%.
The diff coverage is 100.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1334         +/-   ##
===================================================
+ Coverage   51.88256%   51.90412%   +0.02156%     
===================================================
  Files             68          68                 
  Lines           4462        4464          +2     
  Branches         834         834                 
===================================================
+ Hits            2315        2317          +2     
  Misses          1851        1851                 
  Partials         296         296                 
Impacted Files Coverage Δ
packages/api/src/controllers/access-control.ts 87.17949% <100.00000%> (+0.69299%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d36972...23d2dca. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/access-control.ts 87.17949% <100.00000%> (+0.69299%) ⬆️

Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit 327839c into master Oct 7, 2022
@victorges victorges deleted the gio/api/publicgate branch October 7, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants