-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the Delete and Update webhook dialogs #1350
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just noticed a few cosmetic issues related to webhooks that we may as well tackle in this issue as well.
- Can we change this border from
$primary7
to$neutral6
- Can we fix this overflow text? Can use an ellipsis...
@adamsoffer I fixed the border color and the long urls overlapping. Good catch. I would suggest that I fix the z-index issue in another PR, given that turns out ALL popups in the app have the same issue. Also, it turns out that ALL popups on smaller screens break. |
Okay yeah in that case let's create a separate issue + PR to fix the dialog. Sounds good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can we just resolve that merge conflict? Then good to merge.
…ladev/webhooks-popup-fix
What does this pull request do? Explain your changes. (required)
Fixes the Delete and Update webhook dialogs, which were displayed behind the body of the content. Fixed the Event selector inside the Create/Update web hook dialog.
Specific updates (required)
How did you test each of these updates (required)
Tested on different browser and dark/light mode.
Does this pull request close any open issues?
Fixes #1340
Screenshots (optional):
Events Select all 3 major browsers: