Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity campaign components #1420

Merged
merged 16 commits into from
Nov 11, 2022
Merged

Sanity campaign components #1420

merged 16 commits into from
Nov 11, 2022

Conversation

jonoroboto
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Specific updates (required)

-

  • How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jonoroboto jonoroboto requested a review from a team as a code owner October 31, 2022 16:10
@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 7:07PM (UTC)

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jonoroboto - looks like the footer is missing? Also can we fix the merge conflicts? Thanks!

@adamsoffer
Copy link
Member

@jonoroboto looks like a cors issue. I can handle 👍

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1420 (a4142d9) into master (75761e0) will decrease coverage by 0.78325%.
The diff coverage is n/a.

❗ Current head a4142d9 differs from pull request most recent head 5161e36. Consider uploading reports for the commit 5161e36 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1420         +/-   ##
===================================================
- Coverage   53.00000%   52.21675%   -0.78325%     
===================================================
  Files             68          68                 
  Lines           4500        4466         -34     
  Branches         846         832         -14     
===================================================
- Hits            2385        2332         -53     
- Misses          1809        1838         +29     
+ Partials         306         296         -10     
Impacted Files Coverage Δ
packages/api/src/controllers/task.ts 12.74510% <0.00000%> (-8.95301%) ⬇️
packages/api/src/task/scheduler.ts 43.22034% <0.00000%> (-6.77966%) ⬇️
packages/api/src/controllers/asset.ts 55.10204% <0.00000%> (-4.24222%) ⬇️
packages/api/src/store/table.ts 70.06369% <0.00000%> (-3.18472%) ⬇️
packages/api/src/controllers/signing-key.ts 60.67416% <0.00000%> (-0.43695%) ⬇️
packages/api/src/controllers/helpers.ts 49.04459% <0.00000%> (-0.30606%) ⬇️
packages/api/src/controllers/stream.ts 50.15974% <0.00000%> (-0.15873%) ⬇️
packages/api/src/parse-cli.ts 31.70732% <0.00000%> (ø)
packages/api/src/middleware/auth.ts 91.34615% <0.00000%> (ø)
packages/api/src/controllers/playback.ts 91.17647% <0.00000%> (+4.68998%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75761e0...5161e36. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/task.ts 12.74510% <0.00000%> (-8.95301%) ⬇️
packages/api/src/task/scheduler.ts 43.22034% <0.00000%> (-6.77966%) ⬇️
packages/api/src/controllers/asset.ts 55.10204% <0.00000%> (-4.24222%) ⬇️
packages/api/src/store/table.ts 70.06369% <0.00000%> (-3.18472%) ⬇️
packages/api/src/controllers/signing-key.ts 60.67416% <0.00000%> (-0.43695%) ⬇️
packages/api/src/controllers/helpers.ts 49.04459% <0.00000%> (-0.30606%) ⬇️
packages/api/src/controllers/stream.ts 50.15974% <0.00000%> (-0.15873%) ⬇️
packages/api/src/parse-cli.ts 31.70732% <0.00000%> (ø)
packages/api/src/middleware/auth.ts 91.34615% <0.00000%> (ø)
packages/api/src/controllers/playback.ts 91.17647% <0.00000%> (+4.68998%) ⬆️

@adamsoffer adamsoffer merged commit afb5d9c into master Nov 11, 2022
@adamsoffer adamsoffer deleted the sanity-campaign-components branch November 11, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants