-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api/vod: Implement last mile for Catalyst pipeline #1439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will be uploading files to the old default bucket (which can become only for direct uploads), while the final files processed by catalyst will go to a different bucket. To fix, send the public URL of the file for processing instead of the uploaded object key. That's what's gonna reach catalyst anyway.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Oh catalyst why do you keep calling after dark
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
===================================================
+ Coverage 52.28700% 53.00000% +0.71300%
===================================================
Files 68 68
Lines 4460 4500 +40
Branches 832 846 +14
===================================================
+ Hits 2332 2385 +53
+ Misses 1832 1809 -23
- Partials 296 306 +10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This implements the last missing pieces to get the E2E flow from Catalyst.
These felt merely bureaucratic so I didn't worry too much about getting it
implemented before we got an e2e flow with task-runner+catalyst first.
Ended up taking a couple of development hours tho so here I am, with the
testing session happening in less than a day lol
Specific updates (required)
files
field in asset to hold the output from task-runner-
Upload some files through VOD pipeline.
Does this pull request close any open issues?
Catalyst VOD.
Checklist: