-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clacladev/bundle size reduction #1454
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ladev/bundle-size-reduction
adamsoffer
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Reduce the bundle size from 1.7Mb to XXXKb.
Specific updates (required)
Why
component give it's not usedNote:
useApi
hooks context is responsible for 700kb in initial JS downloadcomponents/Dashboard/Table
is responsible for 1Mb of initial JS download (includesuseApi
)These were not tackled since it's not immediate how they can be made leaner. But I tracked them as future work here #1459
How did you test each of these updates (required)
Tested the website on Safari and Chrome.
Does this pull request close any open issues?
Fixes #1453
Checklist:
Build sizes
Before:
After:
Dependencies representation
Client side before
Client side after
Server side before
Server side after
Here the files to have an interactive analysis:
Client side analysis
client.html.txt
Server side analysis
server.html.txt
Download and set
.html
extension and open in browser.