Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api/queue: Add support for a global CloudAMQP rabbit setup #1457

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

victorges
Copy link
Member

What does this pull request do? Explain your changes. (required)

This adds support for a global RabbitMQ setup by allowing to split tasks events into different regions.

Notice that webhooks are still global, but I think that's OK. Only recordings might get processed in a
different region from the original stream.

Specific updates (required)

  • Receive exchange name from CLI args
  • Use it to create the exchange and queues

-

  • How did you test each of these updates (required)
    Deployed to staging and checked CloudAMQP.

Does this pull request close any open issues?
Fixes all my rabbit nightmares.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@victorges victorges requested a review from a team as a code owner November 13, 2022 15:55
@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 3:55PM (UTC)

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #1457 (f094023) into master (afb5d9c) will decrease coverage by 0.00399%.
The diff coverage is 69.23077%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1457         +/-   ##
===================================================
- Coverage   53.00000%   52.99601%   -0.00399%     
===================================================
  Files             68          68                 
  Lines           4500        4506          +6     
  Branches         846         850          +4     
===================================================
+ Hits            2385        2388          +3     
- Misses          1809        1812          +3     
  Partials         306         306                 
Impacted Files Coverage Δ
packages/api/src/app-router.ts 51.28205% <ø> (ø)
packages/api/src/controllers/asset.ts 59.34426% <0.00000%> (ø)
packages/api/src/parse-cli.ts 31.70732% <ø> (ø)
packages/api/src/store/queue.ts 70.76923% <75.00000%> (-2.11213%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d421fa9...f094023. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/app-router.ts 51.28205% <ø> (ø)
packages/api/src/controllers/asset.ts 59.34426% <0.00000%> (ø)
packages/api/src/parse-cli.ts 31.70732% <ø> (ø)
packages/api/src/store/queue.ts 70.76923% <75.00000%> (-2.11213%) ⬇️

Copy link
Member Author

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review LGTM cause I can't wait to deploy this

@victorges victorges merged commit 7ebdd6c into master Nov 14, 2022
@victorges victorges deleted the vg/feat/cloud-rabbits branch November 14, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant