Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www/asset: Fix "processing" progress update #1458

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

victorges
Copy link
Member

@victorges victorges commented Nov 13, 2022

What does this pull request do? Explain your changes. (required)

This introduces a little delay after finishing upload so that there's time for the
task to start executing. This will guarantee that we will show a swift update from
"uploading 100%" to "processing x%" instead of taking up to 10 seconds depending
on the refresh interval.

Specific updates (required)
Create a sleep helper and use it to delay state invalidation.

-

  • How did you test each of these updates (required)
    Upload on the vercel preview and check described behavior.

Does this pull request close any open issues?
No only my "OCD".

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Nov 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Nov 13, 2022 at 8:38PM (UTC)

@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Merging #1458 (4402765) into master (afb5d9c) will not change coverage.
The diff coverage is 0.00000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              master       #1458   +/-   ##
=============================================
  Coverage   53.00000%   53.00000%           
=============================================
  Files             68          68           
  Lines           4500        4500           
  Branches         846         846           
=============================================
  Hits            2385        2385           
  Misses          1809        1809           
  Partials         306         306           
Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 59.34426% <0.00000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d421fa9...4402765. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/asset.ts 59.34426% <0.00000%> (ø)

@victorges victorges marked this pull request as ready for review November 13, 2022 20:24
@victorges victorges requested a review from a team as a code owner November 13, 2022 20:24
Copy link
Member

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges merged commit cea52fa into master Nov 14, 2022
@victorges victorges deleted the vg/fix/asset-upload-progress-snap branch November 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants