Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Grid refator working nicely #1484

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

jonoroboto
Copy link
Collaborator

What does this pull request do? Explain your changes. (required)

Specific updates (required)

-

  • How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jonoroboto jonoroboto requested a review from a team as a code owner November 18, 2022 16:03
@vercel
Copy link

vercel bot commented Nov 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Nov 18, 2022 at 4:06PM (UTC)

Copy link
Member

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -41,7 +41,8 @@ export default function IconGrid({ title, richText, icons, portableTextRaw }) {
<Box
sx={{
display: ["block", "flex"],
justifyContent: ["unset", "space-between"],
flexWrap: "wrap",
justifyContent: ["unset", "center"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this "unset" necessary? I'm not familiar with this array styling feature, would this just set center as justify-content?

@adamsoffer adamsoffer merged commit 2b8fcda into master Nov 18, 2022
@adamsoffer adamsoffer deleted the hotfix-icon-grid-frontend-fix branch November 18, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants