Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing more user friendly error when the email is already registered #1538

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

clacladev
Copy link
Contributor

@clacladev clacladev commented Dec 7, 2022

What does this pull request do? Explain your changes. (required)
Showing more user friendly error when the email is already registered. Also looking for lowercase email when logging in, verifying email and resetting password.

Specific updates (required)

  • Looking up for the email (as given and lowercased before registering)
  • Registering with 3rd parties and in our DB the lowercase version of the email
  • Looking for lowercase email when logging in, verifying email and resetting password.

How did you test each of these updates (required)

  • Updated the unit tests
  • Run locally the API server and made sure it was passing all the tests
  • Manually tested in browser

Does this pull request close any open issues?
Fixes #1531
Fixes #1522

Screenshots:
Screenshot 2022-12-07 at 17 21 58

@clacladev clacladev requested a review from a team as a code owner December 7, 2022 17:21
@vercel
Copy link

vercel bot commented Dec 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Dec 7, 2022 at 6:06PM (UTC)

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #1538 (7cc7ccb) into master (3cddfa5) will increase coverage by 0.05526%.
The diff coverage is 83.33333%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #1538         +/-   ##
===================================================
+ Coverage   53.03197%   53.08723%   +0.05526%     
===================================================
  Files             68          68                 
  Lines           4535        4551         +16     
  Branches         855         860          +5     
===================================================
+ Hits            2405        2416         +11     
- Misses          1820        1825          +5     
  Partials         310         310                 
Impacted Files Coverage Δ
packages/api/src/controllers/user.ts 42.60355% <83.33333%> (+1.60976%) ⬆️
packages/api/src/store/table.ts 72.61146% <0.00000%> (-0.63695%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cddfa5...7cc7ccb. Read the comment docs.

Impacted Files Coverage Δ
packages/api/src/controllers/user.ts 42.60355% <83.33333%> (+1.60976%) ⬆️
packages/api/src/store/table.ts 72.61146% <0.00000%> (-0.63695%) ⬇️

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsoffer adamsoffer merged commit cb8d298 into master Dec 15, 2022
@adamsoffer adamsoffer deleted the clacladev/email-registration-error branch December 15, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants