Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing errors for files that failed to request upload #1560

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

clacladev
Copy link
Contributor

What does this pull request do? Explain your changes. (required)
Showing errors for files that failed to request upload

Specific updates (required)
Showing errors for VOD uploads that fail at the request-upload api call step. They will be shown in a toast

How did you test each of these updates (required)
I run the api server locally and forced an error.

Does this pull request close any open issues?
Fixes #1540

Screenshots (optional)
Screenshot 2022-12-15 at 14 36 42

Checklist
This should be tested with the live environment.

@clacladev clacladev requested a review from a team as a code owner December 15, 2022 14:39
@vercel
Copy link

vercel bot commented Dec 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
livepeer-studio ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 2:39PM (UTC)

Copy link
Member

@adamsoffer adamsoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamsoffer adamsoffer merged commit 50a9721 into master Dec 15, 2022
@adamsoffer adamsoffer deleted the clacladev/error-on-upload-hit-rate-limit branch December 15, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload modal should error when user has hit rate limit
2 participants