api: Implement IPFS storage on upload #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Basically copied the patch logic to upload!
victorges
force-pushed
the
vg/feat/upload-ipfs
branch
from
5809fa0
to
d27c073
Compare
gioelecerati
approved these changes
Mar 9, 2023
| properties: | ||
| spec: | ||
| oneOf: | ||
| - type: "null" |
There was a problem hiding this comment.
Just out of curiosity, I saw it was already like that, but Is this how the null type is defined here? Is it required to be a string in quotation marks?
There was a problem hiding this comment.
Hmm, actually for YAML it's just a string, but I think null is a special keyword since it also exists in JSON. If we used null here, this object would have a {"type": null} field (no type on JSON) instead of a {"type": "null"} (null type on JSON schema). ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Basically copied the patch logic to upload and that's it!
Specific updates (required)
new-asset-payloadand reference it from patchstorageInputrequest to the asset statestoragefield on the created assettask-runnerwill already copy the asset to IPFS hereHow did you test each of these updates (required)
Actually haven't, only a PoC and it's pretty late.
Should be pretty easy tho just call any
/uploadendpoint withstorage.ipfs = truefor example.Does this pull request close any open issues?
Implements API-17
Checklist